Skip to content

CLN: Fix all flake8 warnings in pandas/tests #12069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CLN: Fix all flake8 warnings in pandas/tests #12069

wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Jan 17, 2016

Ouch my wrists. I will rebase and fix the post-rebase entropy tomorrow.

@wesm
Copy link
Member Author

wesm commented Jan 17, 2016 

22:54 ~/code/pandas  (style/flake8-pandas-tests)$ git diff master --stat
 pandas/tests/frame/test_operators.py        |    2 +-
 pandas/tests/test_algos.py                  |  253 ++++----
 pandas/tests/test_base.py                   |  296 +++++----
 pandas/tests/test_categorical.py            | 2294 +++++++++++++++++++++++++++++++++++++---------------------------
 pandas/tests/test_common.py                 |  400 ++++++------
 pandas/tests/test_compat.py                 |   20 +-
 pandas/tests/test_config.py                 |   13 +-
 pandas/tests/test_dtypes.py                 |   57 +-
 pandas/tests/test_expressions.py            |  135 ++--
 pandas/tests/test_format.py                 | 1051 +++++++++++++++---------------
 pandas/tests/test_generic.py                |  685 ++++++++++---------
 pandas/tests/test_graphics.py               |  686 +++++++++++---------
 pandas/tests/test_graphics_others.py        |  182 ++++--
 pandas/tests/test_groupby.py                | 2448 ++++++++++++++++++++++++++++++++++++--------------------------------
 pandas/tests/test_index.py                  | 1427 ++++++++++++++++++++++------------------
 pandas/tests/test_indexing.py               | 4188 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------
 pandas/tests/test_internals.py              |  308 +++++----
 pandas/tests/test_lib.py                    |   29 +-
 pandas/tests/test_msgpack/test_case.py      |   64 +-
 pandas/tests/test_msgpack/test_except.py    |   19 +-
 pandas/tests/test_msgpack/test_extension.py |   42 +-
 pandas/tests/test_msgpack/test_format.py    |   96 +--
 pandas/tests/test_msgpack/test_limits.py    |   24 +-
 pandas/tests/test_msgpack/test_newspec.py   |   24 +-
 pandas/tests/test_msgpack/test_obj.py       |   29 +-
 pandas/tests/test_msgpack/test_pack.py      |   57 +-
 pandas/tests/test_msgpack/test_read_size.py |    6 +-
 pandas/tests/test_msgpack/test_seq.py       |   16 +-
 pandas/tests/test_msgpack/test_sequnpack.py |    6 +-
 pandas/tests/test_msgpack/test_subtype.py   |    7 +-
 pandas/tests/test_msgpack/test_unpack.py    |    7 +-
 pandas/tests/test_multilevel.py             |  498 +++++++-------
 pandas/tests/test_nanops.py                 |  418 +++++-------
 pandas/tests/test_panel.py                  |  780 +++++++++++-----------
 pandas/tests/test_panel4d.py                |   70 +-
 pandas/tests/test_panelnd.py                |   20 +-
 pandas/tests/test_reshape.py                |  347 ++++++----
 pandas/tests/test_rplot.py                  |   39 +-
 pandas/tests/test_series.py                 | 2066 +++++++++++++++++++++++++++++++---------------------------
 pandas/tests/test_stats.py                  |   19 +-
 pandas/tests/test_strings.py                |  497 +++++++-------
 pandas/tests/test_style.py                  |   74 ++-
 pandas/tests/test_testing.py                |  175 +++--
 pandas/tests/test_tseries.py                |  151 ++---
 pandas/tests/test_util.py                   |    6 +-
 pandas/tests/test_window.py                 | 1488 +++++++++++++++++++++++-------------------
 46 files changed, 11978 insertions(+), 9541 deletions(-)

@wesm
Copy link
Member Author

wesm commented Jan 17, 2016

I had to disable flake8 checking on a couple of modules. I left TODO notes about it per #12066 mainly

@wesm wesm force-pushed the style/flake8-pandas-tests branch from 6f68fbc to 588b255 Compare January 17, 2016 13:45
@wesm
Copy link
Member Author

wesm commented Jan 17, 2016

Rebased on master. @jreback feel free to merge if Travis is green

@jreback jreback added Testing pandas testing functions or related to the test suite Code Style Code style, linting, code_checks labels Jan 17, 2016
@jreback jreback added this to the 0.18.0 milestone Jan 17, 2016
@jreback jreback closed this in 431923f Jan 17, 2016
@jreback
Copy link
Contributor

jreback commented Jan 17, 2016

merged (with new merge-pr.py script). thanks!

@jreback
Copy link
Contributor

jreback commented Jan 17, 2016

looking pretty good! not much left at all

linting [ok_for_now] -> pandas/tests
6       E402 module level import not at top of file
1       E711 comparison to None should be 'if cond is None:'
13      W503 line break before binary operator

@wesm wesm deleted the style/flake8-pandas-tests branch January 18, 2016 00:32
@wesm
Copy link
Member Author

wesm commented Jan 18, 2016

Weird, I wonder why those aren't showing up for me locally. Good progress though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wesm @jreback